Skip to content

Fix typo in error message for runtime validation #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

Fix typo in error message for runtime validation #9458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c0d158
Fix typo in error message for runtime validation
ytetsuro Nov 13, 2025
eea38f0
fix double quote to back quote.
ytetsuro Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/deploy/functions/runtimes/node/parseRuntimeAndValidateSDK.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ const supportedNodeVersions: string[] = Object.keys(supported.RUNTIMES)
.map((s) => s.substring("nodejs".length));

export const RUNTIME_NOT_SET =
"`runtime` field is required but was not found in firebase.json or package.json.\n" +
"To fix this, add the following lines to the `functions` section of your firebase.json:\n" +
`"runtime": "${supported.latest("nodejs")}" or set the "engine" field in package.json\n`;
`\`runtime\` field is required but was not found in firebase.json or package.json.
To fix this, add the following lines to the \`functions\` section of your firebase.json:
"runtime": "${supported.latest("nodejs")}" or set the "engines" field in package.json`;
Comment on lines +16 to +18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While fixing the typo is a great improvement, the error message could be made even clearer. The current phrasing might be ambiguous to users about how to resolve the issue. Presenting the two available options as a numbered list would improve readability and provide a better user experience.

  `\`runtime\` field is required but was not found in firebase.json or package.json.\nTo fix this, please specify a runtime in either of the following ways:\n1. Add \`"runtime": "${supported.latest("nodejs")}"\` to the \`functions\` section of your firebase.json.\n2. Set the \`engines\` field in your package.json (e.g. \`"engines": { "node": "20" }\`).`


function getRuntimeChoiceFromPackageJson(sourceDir: string): supported.Runtime {
const packageJsonPath = path.join(sourceDir, "package.json");
Expand Down