-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix second init on spark account not allowing choosing a sql instance #9504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tammam-g
wants to merge
21
commits into
master
Choose a base branch
from
tammam/fdc-ift-fix-init
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−7
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
05491db
Starting to make billing optional
joehan eb415d4
Finish removing billing requirements
joehan 739750d
Fixing tests
joehan f846baf
Merge branch 'master' into jh-fdc-ift
joehan 40f3091
Clean up
joehan c60aafc
Format
joehan 6a7dce6
One more usage of removed variable
joehan 7fd6757
Merge branch 'master' into tammam/fdc-iftrial
tammam-g c5e7164
Improve gating for when to indicate a free trial is avaialbe + format…
tammam-g 87a38be
Fix inversed if statement
tammam-g db82c8a
improves when messages show about free trial availability
tammam-g d5304e1
Use expirement flag and make flow identical when flag is disabled
tammam-g 0a001dc
fix formatting
tammam-g 7e7ab32
Merge branch 'master' into tammam/fdc-iftrial
tammam-g 434d6b3
fix tests
tammam-g 00f4d04
cleanup
tammam-g e9dac78
Merge branch 'master' into tammam/fdc-iftrial
tammam-g f9ce8f6
Fix tests
tammam-g bdd64c8
format fix
tammam-g a5a05f0
Fix init flow to allow choosing a free instance on repeated inits on …
tammam-g 5ce4149
Merge branch 'master' into tammam/fdc-ift-fix-init
tammam-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
promptForCloudSQLfunction includes a guard at the beginning (if (!setup.projectId) { return; }), which ensures thatsetup.projectIdis always defined at this point in the code. Consequently, the fallback to"your-firebase-project"is redundant.Removing this fallback and relying on the established contract that
setup.projectIdexists will make the code cleaner and prevent the generation of a non-functional URL in the unlikely scenario that the initial guard is removed andsetup.projectIdis falsy.