Remove tools and prompts that rely on GiF ToS

[joehan]

Description

Remove dataconnect_generate_operation, dataconnect_generate_schema, and /firebase:consult, to fully remove the reliance on GiF ToS.

Alternatively, we could remove just the tools, and add a ToS disclaimer to the description of /firebase:consult

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on removing specific tools and prompts that had a direct dependency on the Gemini in Firebase Terms of Service (GiF ToS). By eliminating these components, the codebase is streamlined, and any implicit or explicit reliance on the GiF ToS is removed, simplifying the overall architecture and user experience regarding these features.

Highlights

• Removed Gemini in Firebase (GiF) dependent prompts: The /firebase:consult prompt, which allowed users to interact with the Firebase Assistant via Gemini, has been entirely removed.
• Removed Gemini in Firebase (GiF) dependent Data Connect tools: The dataconnect_generate_operation and dataconnect_generate_schema tools, which relied on Gemini for generating Data Connect queries, mutations, and schemas, have been removed.
• Removed GiF Terms of Service acceptance option: The accept_gemini_tos argument and its associated logic have been removed from the update_environment tool, eliminating the ability to accept GiF ToS through this mechanism.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes tools and prompts that rely on the Gemini in Firebase Terms of Service. The changes are focused and achieve the stated goal. My review includes a few suggestions to remove what appears to be dead code left over from these changes, which will help with long-term maintainability.

I am having trouble creating individual review comments. Click here to see my feedback.

src/mcp/prompts/core/index.ts (3-5)

With the removal of the consult prompt, its underlying implementation chatWithFirebase in src/gemini/fdcExperience.ts and the requireGeminiToS check in src/mcp/errors.ts appear to be unused. Consider removing this dead code to improve maintainability.

src/mcp/tools/core/update_environment.ts (34-39)

Since the accept_gemini_tos option is being removed, the GEMINI_TOS_ERROR in src/mcp/errors.ts which directs users to use this option is now outdated and misleading. This error constant and the requireGeminiToS function that uses it appear to be dead code and should probably be removed as part of this cleanup.

src/mcp/tools/dataconnect/index.ts (8-14)

With the removal of generate_schema and generate_operation from dataconnectTools, their underlying implementations in src/gemini/fdcExperience.ts (the generateSchema and generateOperation functions) appear to be dead code. To complete the cleanup and improve maintainability, consider removing them and other related unused code from the project.

[fredzqm]

Sad. Hopefully, we will see them back soon