Cloud Run No Build Initial MVP Implementation v2 #9707
Conversation
Summary of ChangesHello @brittanycho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers the foundational components for 'no-build' deployments to Cloud Run, primarily focusing on enabling Dart 3 functions. It allows developers to specify Cloud Run service configurations directly through a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for a "no build" deployment to Cloud Run for Firebase Functions, a significant new feature. The changes are extensive, touching deployment logic, configuration parsing, and adding a new runtime delegate for Dart. The implementation correctly adds a new "run" platform, handles tar.gz packaging for the source, and uses the Cloud Run v2 API for deployment. The addition of manual verification files and new tests is a good practice.
I have a couple of suggestions for improving code quality:
- There are several instances of empty JSDoc comments being added. These should be removed or filled with meaningful content.
- The new
nobuildruntime delegate uses severalas anytype assertions that are no longer necessary due to updated type definitions. Removing them will improve type safety.
Overall, this is a solid MVP implementation.
| }, | ||
| client: "cli-firebase", | ||
| labels: { ...endpoint.labels, "goog-managed-by": "firebase-functions" }, | ||
| annotations: {}, |
There was a problem hiding this comment.
I see few missing configs like
- timeout
- serviceAccount
- labels for triggers, like callable function, scheduled function, etc
- env vars
Fix or leave a todo?
| } | ||
| const configForUpload = shouldUseRuntimeConfig(localCfg) ? runtimeConfig : undefined; | ||
| const exportType = backend.someEndpoint(wantBackend, (e) => e.platform === "run") | ||
| ? "tar.gz" |
There was a problem hiding this comment.
nit* I think zip deploy may add support for .zip soonish?
There was a problem hiding this comment.
I see, do you think above would be best to add as a todo once they add the support or preemptively add it now?
2 participants
Cloud Run No Build Initial MVP Implementation v2