-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding a script to count tokens used by a skill #9721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a valuable new developer tool: a TypeScript-based script for precisely measuring the token length of skill definitions. By analyzing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a useful utility script for counting tokens in a skill definition. The script is well-structured, but it contains a critical bug in how it interacts with the Google GenAI SDK, which will prevent it from running correctly. I've provided a comment with a suggested fix for the client initialization and token counting logic. I've also suggested a performance improvement to process reference files in parallel, which will make the script faster when dealing with multiple files. The package and TypeScript configurations are well-defined.
Description
Useful little utility to check whether a skill is the appropriate token length.
To use it,
npm iin theskill-token-counterdirectory, set theGEMINI_API_KEYenv var, and thennpm run count ../../skills/firestore-basicsScenarios Tested