-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ability to set a runtime flag in the CLI #9726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @falahat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase CLI's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the ability to specify a runtime via a new --runtime flag in the CLI when creating an App Hosting backend. The implementation is straightforward and includes new unit tests to cover the changes. My review includes a couple of suggestions to improve code maintainability by reducing duplication in both the core logic and the tests.
Description
Adding the ability to set a runtime version in the CLI when creating a backend.
Scenarios Tested
Note, I havent tested these yet, but it's the plan:
is created with the default nodejs runtime.
verify the backend is created with the nodejs22 runtime.
runtime to the App Hosting API.
Sample Commands
Create a backend with a specific runtime:
Create a backend non-interactively (defaults to nodejs runtime):
Create a backend non-interactively with a specific runtime:
Prompt for runtime selection in interactive mode:
Today, the list of valid runtimes is hardcoded but the CLI will be able to call the Control Plane API, ListSupportedRuntimes, to fetch the list live.
Create a backend with an empty runtime (defaults to nodejs runtime):
Create a backend with an unsupported runtime (expected to fail):