express: avoid shell interpolation in npm pack

[staticpayload]

Context\nThe express codegen path invokes

[email protected] prepare
npm run clean && npm run build:publish

[email protected] clean
node -e "fs.rmSync('lib', { recursive: true, force: true }); fs.rmSync('dev', { recursive: true, force: true });"

[email protected] build:publish
tsc --build tsconfig.publish.json && npm run copyfiles via a shell. If the project path includes shell metacharacters, the command can be interpreted by the shell.\n\n## Change\nCall npm via execFileSync with explicit args, and add a regression test that uses a path with spaces.\n\n## Testing\n- Ubuntu 22.04 (AWS eu-west-2), Node 20\n- npx mocha --no-config --require ts-node/register --require source-map-support/register --require src/test/helpers/mocha-bootstrap.ts --file src/test/helpers/global-mock-auth.ts src/frameworks/express/index.spec.ts

[gemini-code-assist]

Summary of Changes

Hello @staticpayload, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential security vulnerability and improves the robustness of command execution within the Express framework integration. By switching to execFileSync for npm pack, it mitigates risks associated with shell interpolation, ensuring that paths with special characters are handled correctly. A new regression test has been introduced to validate this fix and prevent future regressions.

Highlights

• Security Fix for npm pack: The npm pack command is now executed using childProcess.execFileSync with arguments passed as an array, preventing potential shell interpolation vulnerabilities, especially with paths containing spaces.
• Improved Build Command Execution: The npm run build command has been updated to use childProcess.execSync instead of a direct execSync import, ensuring consistent use of the child_process module.
• New Regression Test: A new test file src/frameworks/express/index.spec.ts has been added to specifically verify that npm pack functions correctly without shell interpolation, particularly for paths that include spaces.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a potential command injection vulnerability by replacing execSync with execFileSync when calling npm pack. This change prevents shell interpolation of the path argument, making the code more secure. The addition of a regression test that uses a path with spaces is excellent, as it directly verifies the fix and prevents future regressions. The changes are well-implemented and focused. Overall, this is a great improvement.