Skip to content

Conversation

@joehan
Copy link
Member

@joehan joehan commented Jan 13, 2026

Description

In apiv2.ts, we have some STANDARD_HEADERS that we include on all requests. We use these to attribute API usage to the CLI.

Currently, they look like:

"User-Agent": FirebaseCLI/${CLI_VERSION},
"X-Client-Version": FirebaseCLI/${CLI_VERSION},

After this change, they will look like

"User-Agent": Firebase${CLI or MCP}$/${CLI_VERSION}/${AgentName or "None"},
"X-Client-Version": Firebase${CLI or MCP}$/${CLI_VERSION}/${AgentName or "None"}

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how API calls are attributed by modifying the User-Agent and X-Client-Version HTTP headers. It introduces a more granular tracking mechanism that identifies whether the call originates from FirebaseCLI or FirebaseMCP, and if an AI agent is involved, it specifies which one. This change centralizes the AI agent detection logic into a shared utility, improving code organization and reusability for future tracking enhancements.

Highlights

  • Enhanced API Call Attribution: The User-Agent and X-Client-Version HTTP headers now include details about the AI agent (if detected) and the platform (FirebaseCLI or FirebaseMCP) making the API call.
  • Centralized AI Agent Detection: The detectAIAgent utility function has been refactored and moved from src/track.ts to src/utils.ts, making it a reusable, exported function.
  • New AI Agent Detection: Added support for detecting the 'antigravity' AI agent via the ANTIGRAVITY_CLI_ALIAS environment variable.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances API call tracking by including AI agent information in the User-Agent and X-Client-Version headers. The implementation correctly moves the detectAIAgent function to a shared utility file for broader use. My review includes a couple of suggestions to improve code maintainability and consistency, such as refactoring the agent detection logic and using an existing helper function for environment checks.

src/apiv2.ts Outdated
Comment on lines 16 to 26
import { detectAIAgent } from "./utils";

// Using import would require resolveJsonModule, which seems to break the
// build/output format.
const pkg = require("../package.json");
const CLI_VERSION: string = pkg.version;

const agent = detectAIAgent();
const agentStr = agent === "unknown" ? "None" : agent;
const platform = process.env.IS_FIREBASE_MCP ? "FirebaseMCP" : "FirebaseCLI";
const clientVersion = `${platform}/${CLI_VERSION}/${agentStr}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and consistency, consider using the isFirebaseMcp function from src/env.ts to determine the platform. This centralizes the logic for checking the environment, as a helper function for this already exists. This change would involve importing isFirebaseMcp and using it to set the platform constant.

Suggested change
import { detectAIAgent } from "./utils";
// Using import would require resolveJsonModule, which seems to break the
// build/output format.
const pkg = require("../package.json");
const CLI_VERSION: string = pkg.version;
const agent = detectAIAgent();
const agentStr = agent === "unknown" ? "None" : agent;
const platform = process.env.IS_FIREBASE_MCP ? "FirebaseMCP" : "FirebaseCLI";
const clientVersion = `${platform}/${CLI_VERSION}/${agentStr}`;
import { detectAIAgent } from "./utils";
import { isFirebaseMcp } from "./env";
// Using import would require resolveJsonModule, which seems to break the
// build/output format.
const pkg = require("../package.json");
const CLI_VERSION: string = pkg.version;
const agent = detectAIAgent();
const agentStr = agent === "unknown" ? "None" : agent;
const platform = isFirebaseMcp() ? "FirebaseMCP" : "FirebaseCLI";
const clientVersion = `${platform}/${CLI_VERSION}/${agentStr}`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant