Renaming generate_rules prompts to generate_security_rules

[joehan]

Description

Implementing suggestions from #9733

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a refactoring effort to enhance the clarity and consistency of naming conventions within the codebase. Specifically, it renames prompt files related to Firebase Firestore and Storage rule generation, ensuring that their names more accurately reflect their purpose of generating security rules. This change improves code readability and maintainability without altering functionality.

Highlights

• File Renaming: The prompt files generate_rules.ts for both Firestore and Storage have been renamed to generate_security_rules.ts to provide more explicit clarity on their function.
• Import Path Updates: Corresponding import statements in src/mcp/prompts/firestore/index.ts and src/mcp/prompts/storage/index.ts were updated to reflect the new file names.
• Changelog Entry: A new entry has been added to CHANGELOG.md to document the renaming of the /firestore:generate_rules and /storage:generate_rules prompts to include 'security' in their names.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request involves a straightforward renaming of generate_rules prompts to generate_security_rules for both Firestore and Storage. The changes are correctly reflected in the imports and usages. My review includes one suggestion for the CHANGELOG.md file to correct the formatting of the prompt names for better accuracy and readability.

[gemini-code-assist]

There's a minor formatting issue in the changelog entry. The prompt names include an unnecessary leading slash, and the backticks for code formatting are misplaced. To accurately reflect the prompt names (e.g., firestore:generate_rules), the slashes should be removed and the backticks should enclose the entire prompt name for correct markdown rendering.

Suggested change

	- Renamed MCP prompts`/firestore:generate_rules` to `/firestore:generate_security_rules` and `/storage:generate_rules` to `/storage:generate_security_rules`.
	- Renamed MCP prompts `firestore:generate_rules` to `firestore:generate_security_rules` and `storage:generate_rules` to `storage:generate_security_rules`.

[avolkovi]

LG but the build looks broken?

[joehan]

Forgot to add the newly renamed files 🤦

[avolkovi]

much better!