Skip to content

Conversation

@rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Jan 21, 2026

Description

This PR passes in secondary schema files to the language server, in addition to main schema files, allowing fields defined in secondary schema files to be used in connectors without showing a compilation error in VSCode.

Scenarios Tested

Sample Commands

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rosalyntan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves compilation errors experienced in the VSCode extension when working with Data Connect projects that utilize secondary schemas. By refining how schema paths are identified and passed to the language client, it ensures that all defined schemas are correctly recognized and processed, leading to a more robust development experience within VSCode.

Highlights

  • Enhanced Schema Path Resolution: The ResolvedDataConnectConfig class now distinguishes between main and secondary schema directories and provides a consolidated list of all relative schema paths, improving how schema locations are managed.
  • Secondary Schema Support in Language Client: The VSCode language client's schema path configuration has been updated to correctly include and process secondary schemas, resolving compilation errors and ensuring all defined schemas are recognized.
  • New Utility for Secondary Schemas: A new utility function, secondarySchemaYamls, was added to src/dataconnect/types.ts to easily extract secondary schema configurations from a Data Connect YAML, streamlining schema management.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for secondary schemas by updating the configuration handling to manage multiple schema paths. The changes are logical and well-implemented. I've provided a couple of suggestions to refactor parts of the code to use a more functional style, which can improve readability and maintainability. Overall, great work on this fix!

@rosalyntan rosalyntan marked this pull request as ready for review January 22, 2026 00:18
@rosalyntan rosalyntan requested review from fredzqm and hlshen January 22, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant