Skip to content

Update NPM in builder image as well #9915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joehan merged 1 commit into from
Feb 12, 2026
+1 −1
Merged

Update NPM in builder image as well #9915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ RUN curl -fsSL --output hub.tgz https://github.com/github/hub/releases/download/
RUN tar --strip-components=2 -C /usr/bin -xf hub.tgz hub-linux-amd64-2.14.2/bin/hub

# Upgrade npm to 10.
RUN npm install --global npm@10.8
RUN npm install --global npm@11.9
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on the preceding line (13) is now outdated as npm is being upgraded to version 11, not 10. Please update the comment to avoid confusion. For example: # Upgrade npm to 11.

Copy link
Contributor

@tonybaroneee tonybaroneee Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah true :)

Loading