Skip to content

Set NOMINMAX for Firestore Windows builds #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Set NOMINMAX for Firestore Windows builds #1185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions firestore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ set(firebase_firestore_src
src/ValueSerializer.cs
)

# Ensure min/max macros don't get declared on Windows
# (so we can use std::min/max).
if(MSVC)
add_definitions(-DNOMINMAX)
endif()

add_subdirectory(src/swig)

firebase_swig_add_library(firebase_firestore_swig
Expand Down
6 changes: 6 additions & 0 deletions firestore/src/swig/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ add_library(firebase_firestore_swig_cpp STATIC

set_property(TARGET firebase_firestore_swig_cpp PROPERTY FOLDER "Firebase Cpp")

# Ensure min/max macros don't get declared on Windows
# (so we can use std::min/max).
if(MSVC)
add_definitions(-DNOMINMAX)
endif()

target_link_libraries(firebase_firestore_swig_cpp
PUBLIC
firebase_app
Expand Down
Loading