Skip to content

Install CMake 3.31.x on runners to override new GitHub default of CMake 4. #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Apr 2, 2025

Description

Provide details of the change, and generalize the change in the PR title above.

Change CMake to an explicit version to avoid incompatibility with new GitHub default version CMake 4.


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jonsimantov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds CMake installation steps to the GitHub Actions workflows. Based on the title, the author suspects that the added steps might be more than strictly necessary. Since no specific files were changed, it appears the changes are limited to the workflow configurations.

Highlights

  • CMake Installation: The pull request introduces CMake installation steps within the GitHub Actions workflows.
  • Workflow Enhancement: The goal is to likely ensure CMake is available for building and testing the project.

Changelog

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A build tool's grace,
CMake finds its rightful place,
In workflows it thrives.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds CMake installation to the workflows. The changes seem straightforward, but I have a few suggestions to improve the workflow definitions.

Merge Readiness

The changes seem reasonable and straightforward. I would recommend addressing the comments before merging. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@jonsimantov jonsimantov requested a review from a-maurice April 2, 2025 22:50
@jonsimantov jonsimantov marked this pull request as ready for review April 2, 2025 22:51
@jonsimantov jonsimantov changed the title Add cmake installation to workflows (probably more than needed). Install CMake 3.31.x on runners to override new GitHub default of CMake 4. Apr 2, 2025
@jonsimantov jonsimantov merged commit 2bc2424 into main Apr 2, 2025
36 of 37 checks passed
@firebase firebase locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants