Skip to content

Commit f0385a3

Browse files
committed
chore(react): Rework tsconfig setup
1 parent 4351302 commit f0385a3

File tree

8 files changed

+12
-30
lines changed

8 files changed

+12
-30
lines changed

packages/react/src/auth/forms/email-link-auth-form.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export function useEmailLinkAuthForm(onSuccess?: EmailLinkAuthFormProps["onEmail
6262
onSubmitAsync: async ({ value }) => {
6363
try {
6464
await action(value);
65-
onSuccess?.();
65+
return onSuccess?.();
6666
} catch (error) {
6767
return error instanceof Error ? error.message : String(error);
6868
}

packages/react/src/auth/forms/forgot-password-auth-form.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export function useForgotPasswordAuthForm(onSuccess?: ForgotPasswordAuthFormProp
6161
onSubmitAsync: async ({ value }) => {
6262
try {
6363
await action(value);
64-
onSuccess?.();
64+
return onSuccess?.();
6565
} catch (error) {
6666
return error instanceof Error ? error.message : String(error);
6767
}

packages/react/src/auth/forms/phone-auth-form.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ function PhoneNumberForm({ onSubmit, recaptchaVerifier, recaptchaContainerRef }:
118118
onSubmitAsync: async ({ value }) => {
119119
try {
120120
const formattedNumber = formatPhoneNumberWithCountry(value.phoneNumber, selectedCountry);
121-
await onSubmit(formattedNumber);
121+
return await onSubmit(formattedNumber);
122122
} catch (error) {
123123
return error instanceof Error ? error.message : String(error);
124124
}
@@ -259,7 +259,7 @@ function VerificationForm({
259259
onSubmit: verificationFormSchema,
260260
onSubmitAsync: async ({ value }) => {
261261
try {
262-
await onSubmit(value.verificationCode);
262+
return await onSubmit(value.verificationCode);
263263
} catch (error) {
264264
return error instanceof Error ? error.message : String(error);
265265
}

packages/react/src/auth/forms/sign-in-auth-form.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export function useSignInAuthForm(onSuccess?: SignInAuthFormProps["onSignIn"]) {
6464
onSubmitAsync: async ({ value }) => {
6565
try {
6666
const credential = await action(value);
67-
onSuccess?.(credential);
67+
return onSuccess?.(credential);
6868
} catch (error) {
6969
return error instanceof Error ? error.message : String(error);
7070
}

packages/react/src/auth/forms/sign-up-auth-form.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export function useSignUpAuthForm(onSuccess?: SignUpAuthFormProps["onSignUp"]) {
6363
onSubmitAsync: async ({ value }) => {
6464
try {
6565
const credential = await action(value);
66-
onSuccess?.(credential);
66+
return onSuccess?.(credential);
6767
} catch (error) {
6868
return error instanceof Error ? error.message : String(error);
6969
}

packages/react/src/components/form.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ function ErrorMessage() {
6363
return (
6464
<form.Subscribe selector={(state) => [state.errorMap]}>
6565
{([errorMap]) => {
66-
if (errorMap.onSubmit) {
67-
return <div className="fui-form__error">{errorMap.onSubmit.toString()}</div>;
66+
if (errorMap?.onSubmit) {
67+
return <div className="fui-form__error">{String(errorMap.onSubmit)}</div>;
6868
}
6969

7070
return null;

packages/react/tsconfig.json

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,14 @@
11
{
2+
"extends": "../../tsconfig.json",
23
"compilerOptions": {
3-
"target": "ES2020",
4-
"useDefineForClassFields": true,
5-
"lib": ["ES2020", "DOM", "DOM.Iterable"],
6-
"module": "ESNext",
7-
"skipLibCheck": true,
8-
"types": ["@testing-library/jest-dom"],
9-
10-
/* Bundler mode */
11-
"moduleResolution": "bundler",
12-
"allowImportingTsExtensions": true,
13-
"isolatedModules": true,
14-
"moduleDetection": "force",
15-
"noEmit": true,
164
"jsx": "react-jsx",
17-
18-
/* Linting */
19-
"strict": true,
20-
"noUnusedLocals": true,
21-
"noUnusedParameters": true,
22-
"noFallthroughCasesInSwitch": true,
23-
"noUncheckedSideEffectImports": true,
24-
"baseUrl": ".",
5+
"moduleResolution": "Bundler",
256
"paths": {
267
"~/*": ["./src/*"],
278
"~/tests/*": ["./tests/*"],
289
"@firebase-ui/core": ["../core/src/index.ts"],
2910
"@firebase-ui/styles": ["../styles/src/index.ts"]
3011
}
3112
},
32-
"include": ["src", "vite.config.ts", "tests", "./setup-test.ts"]
13+
"include": ["src", "eslint.config.js", "vite.config.ts", "setup-test.ts"]
3314
}

packages/react/vite.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export default defineConfig({
2525
resolve: {
2626
alias: {
2727
"@firebase-ui/core": path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../core/src"),
28+
"@firebase-ui/styles": path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../styles/src"),
2829
"~/tests": path.resolve(path.dirname(fileURLToPath(import.meta.url)), "./tests"),
2930
"~": path.resolve(path.dirname(fileURLToPath(import.meta.url)), "./src"),
3031
},

0 commit comments

Comments
 (0)