Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,29 @@ on:
- "**"

jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '20'
check-latest: true
- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: latest
- name: Install dependencies
run: pnpm install
- name: Run ESLint on core packages
run: pnpm --filter="@firebase-ui/*" run lint
- name: Run ESLint on example apps
run: pnpm --filter="angular-example" --filter="nextjs" --filter="react" run lint
- name: Check Prettier formatting
run: pnpm format:check

test:
runs-on: ubuntu-latest
steps:
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ dist-ssr
# Angular
.angular

# Next.js
.next

# Coverage
coverage

Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ releases/
# Generated files
*.min.js
*.min.css
packages/styles/dist.css

# Logs
*.log
Expand Down
62 changes: 0 additions & 62 deletions eslint.config.js

This file was deleted.

11 changes: 9 additions & 2 deletions examples/angular/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

import js from "@eslint/js";
import prettier from "eslint-config-prettier";
import typescript from "@typescript-eslint/eslint-plugin";
import typescriptParser from "@typescript-eslint/parser";

export default [
{ ignores: ["dist/**", "node_modules/**", ".angular/**"] },
Expand All @@ -26,13 +28,18 @@ export default [
languageOptions: {
ecmaVersion: 2022,
sourceType: "module",
parser: typescriptParser,
parserOptions: {
project: "./tsconfig.json",
},
},
plugins: {
"@typescript-eslint": typescript,
},
rules: {
"no-unused-vars": ["error", { varsIgnorePattern: "^_", argsIgnorePattern: "^_" }],
"no-console": "warn",
"no-unused-vars": "off", // Use TypeScript version instead
"no-console": "off", // Allow console in examples
"no-undef": "off", // TypeScript handles this
"prefer-const": "error",
"no-var": "error",
"@typescript-eslint/no-explicit-any": "warn",
Expand Down
5 changes: 4 additions & 1 deletion examples/angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "angular-example",
"version": "0.0.0",
"type": "module",
"scripts": {
"ng": "ng",
"start": "ng serve",
Expand Down Expand Up @@ -51,6 +52,8 @@
"@types/jasmine": "~5.1.0",
"@types/node": "^20.19.0",
"eslint": "^9.22.0",
"@typescript-eslint/eslint-plugin": "^8.43.0",
"@typescript-eslint/parser": "^8.43.0",
"eslint-config-prettier": "^9.1.0",
"firebase": "^11",
"jasmine-core": "~5.5.0",
Expand All @@ -64,4 +67,4 @@
"prettier": "^3.1.1",
"typescript": "~5.9.2"
}
}
}
9 changes: 9 additions & 0 deletions examples/nextjs/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"extends": ["next/core-web-vitals"],
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint"],
"rules": {
"@typescript-eslint/no-explicit-any": "warn",
"no-console": "off"
}
}
4 changes: 4 additions & 0 deletions examples/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@
"@types/node": "^20",
"@types/react": "^19",
"@types/react-dom": "^19",
"eslint": "^9.22.0",
"eslint-config-next": "^15.1.7",
"@typescript-eslint/eslint-plugin": "^8.43.0",
"@typescript-eslint/parser": "^8.43.0",
"postcss": "^8.5.2",
"postcss-load-config": "^6.0.1",
"prettier": "^3.1.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/core/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default [
"@typescript-eslint": tseslint,
},
rules: {
"no-unused-vars": "off", // Turn off base rule
"no-unused-vars": "off",
"no-console": "warn",
"prefer-const": "error",
"no-var": "error",
Expand Down Expand Up @@ -75,7 +75,7 @@ export default [
"@typescript-eslint": tseslint,
},
rules: {
"no-unused-vars": "off", // Turn off base rule
"no-unused-vars": "off",
"no-console": "warn",
"prefer-const": "error",
"no-var": "error",
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/dist.css

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/styles/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"./tailwind": "./src/base.css",
"./themes/*": "./src/themes/*.css"
},
"sideEffects": ["**/*.css"],
"sideEffects": [
"**/*.css"
],
"files": [
"dist.css",
"src"
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/src.css
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

@layer theme, components, utilities;

/* Bring in theme vars so Tailwind can resolve tokens in @apply */
/* Bring in theme vars so Tailwind can resolve tokens in @apply */
@import "tailwindcss/theme.css" layer(theme);

/* Load utilities so @apply can expand, but do NOT emit any utility classes */
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/src/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

@layer theme {
@layer theme {
:root {
/* The primary color is used for the button and link colors */
--fui-primary: var(--color-black);
Expand Down
Loading