-
Couldn't load subscription status.
- Fork 1.1k
chore(*): upgraded phone-auth-screen-component #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dackers86
wants to merge
42
commits into
@invertase/align-update-angular
from
@invertase/phone-auth-screen-update
Closed
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
a275905
fix(*): update Firebase peer dependencies to support v11 and v12
dackers86 a51d40c
fix(core): added translations as a core dependency
dackers86 e5ec6d2
fix(packages): move translations to peer dependencies in core package
dackers86 7e28ce2
fix(angular): remove redundant translations peer dependency
dackers86 406f446
chore(angular): Align angular dependencies
Ehesp 21ec181
chore(*): merged latest
dackers86 d03832c
Merge branch '@invertase/v7-development' into @invertase/fix-peer-dep…
dackers86 7e8c704
chore(*): updated depenencies for angular and core
dackers86 09c9867
fix(styles): Strip tailwind pre-flight from dist output
Ehesp 008f3e5
fix(styles): Strip tailwind pre-flight from dist output
dackers86 99085ec
chore(*): merge latest
dackers86 36bf7d9
chore(angular): moved translations to be a main dependency
dackers86 69d5f24
feat(styles): Apply dark mode styles to root theme
Ehesp 7af2bbb
feat(styles): Apply dark mode styles to base theme
dackers86 1835e4f
fix(angular):removed translation dependency
dackers86 74c5273
chore(core): formatted dependencies in package json
dackers86 35c56ee
chore(angular): added licensing
dackers86 c2f16fc
fix(*): updated peer dependencies
dackers86 76bc7eb
feat(*): migrate to vitest for angular
dackers86 8260c29
fix: Angular Vitest test configuration and compatibility issues
dackers86 70d5386
fix: resolve DividerComponent dependency injection issues
dackers86 4070d55
fix: resolve component ID collision issues
dackers86 4e7873c
fix: attempt to resolve duplicate country keys issue
dackers86 6574119
BREAKTHROUGH: Solve Zone.js ProxyZone issue with async/await pattern
dackers86 28bcb91
Continue Zone.js ProxyZone fixes with async/await pattern
dackers86 da79b45
Fix OAuth Button Component tests with async/await pattern
dackers86 a68ca7f
Fix Terms and Privacy Component tests with async/await pattern
dackers86 b1ab6c5
Fix remaining Screen Component tests with async/await pattern
dackers86 cf4f380
Fix all Integration Tests with async/await pattern
dackers86 ffaac88
feat: migrate Angular example from Jasmine+Karma to Vitest
dackers86 3878395
fix: update pnpm-lock.yaml to sync Vitest versions
dackers86 9a13194
fix: properly skip problematic OAuth test instead of throwing error
dackers86 8314858
refactor: remove all Jasmine syntax from test files
dackers86 8abee7f
refactor: clean up test-setup.ts files
dackers86 9a01082
chore: final cleanup of Jasmine/Karma references
dackers86 311508e
revert: restore original Kosovo country codes
dackers86 b0448fc
chore(*): upgraded phone-auth-screen-component
dackers86 26ee384
fix(angular): update template props to functions
dackers86 baa0fee
Merge pull request #1193 from firebase/@invertase/add-angular-vitest
Ehesp a5024be
chore(*): merged latest
dackers86 79ea067
fix(angular): reworked component
dackers86 9d14645
Merge branch '@invertase/align-update-angular' of https://github.com/…
dackers86 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ | |
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { Component, inject, Input, AfterContentInit, ViewChild, ElementRef } from "@angular/core"; | ||
| import { Component, EventEmitter, Output, AfterContentInit, ViewChild, ElementRef } from "@angular/core"; | ||
| import { CommonModule } from "@angular/common"; | ||
| import { | ||
| CardComponent, | ||
|
|
@@ -23,7 +23,7 @@ import { | |
| CardSubtitleComponent, | ||
| CardContentComponent, | ||
| } from "../../../components/card/card.component"; | ||
| import { FirebaseUI } from "../../../provider"; | ||
| import { injectSignInAuthFormSchema, injectTranslation, injectUI } from "../../../provider"; | ||
| import { PhoneFormComponent } from "../../forms/phone-form/phone-form.component"; | ||
| import { DividerComponent } from "../../../components/divider/divider.component"; | ||
|
|
||
|
|
@@ -44,14 +44,14 @@ import { DividerComponent } from "../../../components/divider/divider.component" | |
| <div class="fui-screen"> | ||
| <fui-card> | ||
| <fui-card-header> | ||
| <fui-card-title>{{ titleText | async }}</fui-card-title> | ||
| <fui-card-subtitle>{{ subtitleText | async }}</fui-card-subtitle> | ||
| <fui-card-title>{{ titleText }}</fui-card-title> | ||
| <fui-card-subtitle>{{ subtitleText }}</fui-card-subtitle> | ||
| </fui-card-header> | ||
| <fui-card-content> | ||
| <fui-phone-form [resendDelay]="resendDelay"></fui-phone-form> | ||
|
|
||
| <ng-container *ngIf="hasContent"> | ||
| <fui-divider>{{ dividerOrLabel | async }}</fui-divider> | ||
| <fui-divider>{{ dividerOrLabel }}</fui-divider> | ||
| <div class="space-y-4 mt-6" #contentContainer> | ||
| <ng-content></ng-content> | ||
| </div> | ||
|
|
@@ -62,9 +62,7 @@ import { DividerComponent } from "../../../components/divider/divider.component" | |
| `, | ||
| }) | ||
| export class PhoneAuthScreenComponent implements AfterContentInit { | ||
| private ui = inject(FirebaseUI); | ||
|
|
||
| @Input() resendDelay = 30; | ||
| private ui = injectUI(); | ||
|
|
||
| @ViewChild("contentContainer") contentContainer!: ElementRef; | ||
| private _hasProjectedContent = false; | ||
|
|
@@ -73,17 +71,11 @@ export class PhoneAuthScreenComponent implements AfterContentInit { | |
| return this._hasProjectedContent; | ||
| } | ||
|
|
||
| get titleText() { | ||
| return this.ui.translation("labels", "signIn"); | ||
| } | ||
| titleText = injectTranslation("labels", "signIn"); | ||
| subtitleText = injectTranslation("labels", "signInToAccount"); | ||
| dividerOrLabel = injectTranslation("labels", "dividerOr"); | ||
|
|
||
| get subtitleText() { | ||
| return this.ui.translation("prompts", "signInToAccount"); | ||
| } | ||
|
|
||
| get dividerOrLabel() { | ||
| return this.ui.translation("messages", "dividerOr"); | ||
| } | ||
| @Output() resendDelay = new EventEmitter<void>(); | ||
|
|
||
| ngAfterContentInit() { | ||
| // Set to true initially to ensure the container is rendered | ||
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.