Skip to content

Conversation

@Gustl22
Copy link
Contributor

@Gustl22 Gustl22 commented Nov 28, 2024

Description

SPM Support for firebase_messaging

Related Issues

#13205

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Gustl22 Gustl22 marked this pull request as draft November 28, 2024 11:31
@Gustl22 Gustl22 marked this pull request as ready for review November 28, 2024 13:46
@Gustl22
Copy link
Contributor Author

Gustl22 commented Nov 28, 2024

Haven't tested macos though, because one needs a provisioning certificate to run (in this case). Not sure why this is mandatory (but was too lazy honestly to create one, as it should be tested in CI anyways (?))

@russellwheatley
Copy link
Member

@Gustl22 - if you open the example app for macOS in Xcode, remove the entitlements for release mode, you don't need a provisioning profile and the app will build.

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! A couple of changes and we'll see what the CI says as there might have to be some import updates in ios src/ code

Gustl22 and others added 2 commits November 28, 2024 16:47
…ssaging/Package.swift

Co-authored-by: Russell Wheatley <[email protected]>
…messaging/Package.swift

Co-authored-by: Russell Wheatley <[email protected]>
@Gustl22
Copy link
Contributor Author

Gustl22 commented Nov 28, 2024

if you open the example app for macOS in Xcode, remove the entitlements for release mode, you don't need a provisioning profile and the app will build.

flutterfire/packages/firebase_messaging/firebase_messaging/example/macos/Runner.xcodeproj: error: Signing for "Runner" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'Runner' from project 'Runner')

Still not able to build although removing the Signing entitlements in the Tagets -> Runner -> Build Settings and setting Signing Team to None in all modes (Debug, Release & Profile).

But I guess it's not that important, if the tests are passing.

@russellwheatley
Copy link
Member

@Gustl22 - I had a quick look at this. It seems flutter_local_notifications package hasn't moved to Swift integration and will therefore run pod install which means that we cannot remove the Podfile here: https://github.com/firebase/flutterfire/blob/main/.github/workflows/scripts/swift-integration.dart#L57

You might want to wrap this in an if condition if(messaging == plugin).

@Gustl22
Copy link
Contributor Author

Gustl22 commented Dec 2, 2024

Sure, @russellwheatley like that: 8c2f133 ?

@russellwheatley
Copy link
Member

@Gustl22 - I've made some updates. Should hopefully get this in soon.

@Gustl22
Copy link
Contributor Author

Gustl22 commented Dec 5, 2024

Thank you for taking care of that and investing the time!

@russellwheatley russellwheatley merged commit 165d2ab into firebase:main Dec 6, 2024
26 checks passed
@firebase firebase locked and limited conversation to collaborators Jan 6, 2025
@Gustl22 Gustl22 deleted the 13205-spm-messaging branch May 21, 2025 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants