-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore(ci): implement best practices for CI caching #17873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mikehardy
wants to merge
5
commits into
firebase:fix-avd-storage
from
mikehardy:@mikehardy/ci-caching-best-practices
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ade40a1
chore(ci): pin android emulator runner action to fixed SHA
mikehardy 6b2bcb4
chore(ci): only cache main - avoid branches LRU evicting main cache
mikehardy 951208b
chore(ci): cache restore/save failures should never break the build
mikehardy 0dd19a5
chore(ci): make github primary cache keys unique so caches update
mikehardy ef66fc8
chore(ci): firebase emulators are cross-platform, share cache across OSs
mikehardy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify visually by noticing the
v2tag is currently attached to this SHA here: ReactiveCircus/android-emulator-runner@b530d96