Skip to content

test(ci): cache key names must include enough information to expire correctly #17943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikehardy wants to merge 2 commits into
base: main
Choose a base branch
from
+44 −32
Open

test(ci): cache key names must include enough information to expire correctly #17943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c89e1e7
ci: cache key names must include enough information to expire correctly
mikehardy Jan 12, 2026
7c66f6e
ci: pods cache keys based on flutter deps, Podfile.lock is not available
mikehardy Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/all_plugins.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
melos-version: '5.3.0'
Expand All @@ -46,6 +48,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
melos-version: '5.3.0'
Expand All @@ -63,6 +67,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
melos-version: '5.3.0'
Expand All @@ -81,6 +87,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
melos-version: '5.3.0'
Expand Down Expand Up @@ -115,6 +123,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
melos-version: '5.3.0'
Expand All @@ -133,6 +143,9 @@ jobs:
- uses: subosito/flutter-action@f2c4f6686ca8e8d6e6d0f28410eeef506ed66aff
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- name: Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
- name: Setup firebase_core example app to test Swift integration
Expand All @@ -158,6 +171,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
melos-version: '5.3.0'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/android.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down
19 changes: 8 additions & 11 deletions .github/workflows/e2e_tests_fdc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- name: Setup PostgreSQL for Linux/macOS/Windows
uses: ikalnytskyi/action-setup-postgres@v7
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
Expand Down Expand Up @@ -164,8 +166,8 @@ jobs:
with:
# Must match the save path exactly
path: tests/ios/Pods
key: ${{ runner.os }}-fdc-pods-v3-${{ hashFiles('tests/ios/Podfile.lock') }}
restore-keys: ${{ runner.os }}-ios-pods-v2
key: ${{ runner.os }}-fdc-pods-${{ hashFiles('tests/pubspec.lock') }}
restore-keys: ${{ runner.os }}-fdc-pods
- name: 'Install Tools'
run: |
sudo npm i -g firebase-tools
Expand All @@ -185,6 +187,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down Expand Up @@ -264,6 +268,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down Expand Up @@ -319,12 +325,3 @@ jobs:
key: ${{ steps.firebase-emulator-cache.outputs.cache-primary-key }}
# Must match the restore path exactly
path: ~/.cache/firebase/emulators
- name: Save Pods Cache
# Branches can read main cache but main cannot read branch cache. Avoid LRU eviction with main-only cache.
if: github.ref == 'refs/heads/main'
uses: actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57
continue-on-error: true
with:
key: ${{ steps.pods-cache.outputs.cache-primary-key }}
# Must match the restore paths exactly
path: tests/ios/Pods
8 changes: 4 additions & 4 deletions .github/workflows/ios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ jobs:
with:
# Must match the save path exactly
path: tests/ios/Pods
key: pods-v3-${{ runner.os }}-${{ hashFiles('tests/ios/Podfile.lock') }}
restore-keys: pods-v3-${{ runner.os }}
key: pods-v3-${{ runner.os }}-ios-${{ hashFiles('tests/pubspec.lock') }}
restore-keys: pods-v3-${{ runner.os }}-ios
- name: 'Install Tools'
run: |
sudo npm i -g firebase-tools
Expand All @@ -79,8 +79,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/macos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ jobs:
with:
# Must match the save path exactly
path: tests/macos/Pods
key: pods-v3-${{ runner.os }}-${{ hashFiles('tests/macos/Podfile.lock') }}
restore-keys: pods-v3-${{ runner.os }}
key: pods-v3-${{ runner.os }}-macos-${{ hashFiles('tests/pubspec.lock') }}
restore-keys: pods-v3-${{ runner.os }}-macos
- name: 'Install Tools'
run: |
sudo npm i -g firebase-tools
Expand All @@ -77,8 +77,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down Expand Up @@ -126,4 +126,4 @@ jobs:
with:
key: ${{ steps.pods-cache.outputs.cache-primary-key }}
# Must match the restore paths exactly
path: tests/ios/Pods
path: tests/macos/Pods
12 changes: 6 additions & 6 deletions .github/workflows/web.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down Expand Up @@ -117,8 +117,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down Expand Up @@ -192,8 +192,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down Expand Up @@ -74,8 +74,8 @@ jobs:
with:
channel: 'stable'
cache: true
cache-key: flutter-${{ runner.os }}
pub-cache-key: pub-${{ runner.os }}
cache-key: "flutter-:os:-:channel:-:version:-:arch:-:hash:"
pub-cache-key: "flutter-pub-:os:-:channel:-:version:-:arch:-:hash:"
- uses: bluefireteam/melos-action@c7dcb921b23cc520cace360b95d02b37bf09cdaa
with:
run-bootstrap: false
Expand Down
Loading