Skip to content

Update node versions #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Update node versions #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b91dfc0
update 1st gen package.json files to Node 20
jhuleatt Jan 30, 2025
16c7aad
update 2nd gen package.json to Node 22
jhuleatt Jan 30, 2025
5d7781c
update dependencies
jhuleatt Jan 30, 2025
b774465
re-run pnpm install
jhuleatt Jan 31, 2025
cd54c8c
update Node workflow
jhuleatt Jan 31, 2025
a25b19f
fix missing promise handling in test
jhuleatt Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test_node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ jobs:
strategy:
matrix:
node-version:
- 18.x
- 22.x
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Cache npm
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
Expand Down
5 changes: 5 additions & 0 deletions Node-1st-gen/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# 1st gen's latest runtime is Node 20
# https://cloud.google.com/functions/docs/runtime-support#node.js
# This setting tells pnpm to use Node 20 for all operations
# https://pnpm.io/npmrc#use-node-version
use-node-version=20.18.2
10 changes: 5 additions & 5 deletions Node-1st-gen/assistant-say-number/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
"description": "Firebase Functions",
"dependencies": {
"actions-on-google": "^2.14.0",
"firebase-admin": "^11.9.0",
"firebase-functions": "^4.4.1"
"firebase-admin": "^13.0.2",
"firebase-functions": "^6.3.0"
},
"devDependencies": {
"eslint": "^8.40.0",
"eslint-plugin-promise": "^6.1.1"
"eslint": "^8.57.1",
"eslint-plugin-promise": "^7.2.1"
},
"scripts": {
"lint": "./node_modules/.bin/eslint --max-warnings=0 .",
Expand All @@ -20,7 +20,7 @@
"compile": "cp ../../../tsconfig.template.json ./tsconfig-compile.json && tsc --project tsconfig-compile.json"
},
"engines": {
"node": "18"
"node": "20"
},
"private": true
}
2,856 changes: 2,856 additions & 0 deletions Node-1st-gen/assistant-say-number/functions/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 6 additions & 5 deletions Node-1st-gen/authenticated-json-api/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
"dependencies": {
"@google-cloud/language": "^3.8.0",
"express": "^4.18.2",
"firebase-admin": "^11.9.0",
"firebase-functions": "^4.4.1"
"firebase-admin": "^13.0.2",
"firebase-functions": "^6.3.0"
},
"devDependencies": {
"eslint": "^8.40.0"
"eslint": "^8.57.1",
"eslint-plugin-promise": "^7.2.1"
},
"scripts": {
"lint": "./node_modules/.bin/eslint --max-warnings=0 .",
Expand All @@ -20,7 +21,7 @@
"compile": "cp ../../../tsconfig.template.json ./tsconfig-compile.json && tsc --project tsconfig-compile.json"
},
"engines": {
"node": "18"
"node": "20"
},
"private": true
}
}
Loading