-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix: Correct product name to "Cloud Functions for Firebase" #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replaced all instances of "Firebase Functions" with the correct product name, "Cloud Functions for Firebase", in READMEs, code comments, and other documentation.
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
@@ -1,4 +1,4 @@ | |||
# Firebase Functions Test (with jest-ts) - Quickstart | |||
# Cloud Functions for Firebase Test (with jest-ts) - Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Cloud Functions for Firebase Test (with jest-ts) - Quickstart | |
# Firebase Functions Test (with jest-ts) - Quickstart |
The library is called firebase-functions-test, so this title probably should stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. I have reverted the title as you suggested.
Node/test-functions-jest/README.md
Outdated
@@ -1,4 +1,4 @@ | |||
# Firebase Functions Test (with jest) - Quickstart | |||
# Cloud Functions for Firebase Test (with jest) - Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Cloud Functions for Firebase Test (with jest) - Quickstart | |
# Firebase Functions Test (with jest) - Quickstart |
The library is called firebase-functions-test, so this title probably should stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. I have reverted the title as you suggested.
Replaced all instances of "Firebase Functions" with the correct product name, "Cloud Functions for Firebase", in READMEs, code comments, and other documentation. Reverted title changes in `Node/test-functions-jest-ts/README.md` and `Node/test-functions-jest/README.md` as requested in the PR review.
Node/test-functions-mocha/README.md
Outdated
@@ -1,4 +1,4 @@ | |||
# Firebase Functions Test (with mocha) - Quickstart | |||
# Cloud Functions for Firebase Test (with mocha) - Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Cloud Functions for Firebase Test (with mocha) - Quickstart | |
# `firebase-functions-test` (with mocha) - Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. I have updated the title as you suggested.
Replaced all instances of "Firebase Functions" with the correct product name, "Cloud Functions for Firebase", in READMEs, code comments, and other documentation. Reverted title changes in `Node/test-functions-jest-ts/README.md` and `Node/test-functions-jest/README.md` as requested in the PR review. Updated title in `Node/test-functions-mocha/README.md` as requested in the PR review.
This change corrects the product name "Firebase Functions" to "Cloud Functions for Firebase" across the entire repository. The changes were made in README files, code comments, and other documentation to ensure consistency and accuracy.
PR created automatically by Jules for task 18434623342753005958