Skip to content

Conversation

@cabljac
Copy link
Contributor

@cabljac cabljac commented Jan 6, 2026

This PR restructures code a bit to extract out some shared logic, using structural types to keep them agnostic wrt the SDK namespaces.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Anthropic plugin's runner logic by extracting shared content block and delta conversion functionalities into new, dedicated converter modules. This change aims to improve code organization, reduce redundancy, and enhance the maintainability of the Anthropic API integrations by centralizing common conversion patterns and leveraging structural typing for broader applicability across different API versions.

Highlights

  • Extracted Shared Converters: Common logic for converting Anthropic content blocks and deltas has been moved into new, dedicated converters/shared.ts and converters/beta.ts modules.
  • Improved Code Reusability: Centralized conversion functions reduce duplication across base.ts, beta.ts, and stable.ts runner implementations.
  • Enhanced Maintainability: The BaseRunner, BetaRunner, and StableRunner classes are simplified by delegating conversion responsibilities to specialized modules.
  • Structural Typing for Agnostic Converters: Structural types are utilized to ensure the new converter functions are agnostic to specific SDK namespaces, promoting flexibility and broader applicability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a well-executed refactoring that extracts shared logic for converting Anthropic API objects into Genkit parts. By moving this logic into a new converters directory with shared, beta, and stable modules, the code is now more organized, easier to maintain, and has less duplication. The use of structural typing in the shared converters to support both stable and beta SDKs is a great design choice. Overall, these changes significantly improve the codebase's structure. I have one minor suggestion to further improve conciseness in one of the new helper functions.

@cabljac cabljac marked this pull request as ready for review January 6, 2026 17:13
@cabljac cabljac enabled auto-merge (squash) January 7, 2026 12:09
@CorieW CorieW force-pushed the anthropic-part-refactor-simple branch from ad8332a to e34b676 Compare January 7, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants