-
Notifications
You must be signed in to change notification settings - Fork 631
refactor(js/plugins/anthropic): extract out some shared converters #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Anthropic plugin's runner logic by extracting shared content block and delta conversion functionalities into new, dedicated converter modules. This change aims to improve code organization, reduce redundancy, and enhance the maintainability of the Anthropic API integrations by centralizing common conversion patterns and leveraging structural typing for broader applicability across different API versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a well-executed refactoring that extracts shared logic for converting Anthropic API objects into Genkit parts. By moving this logic into a new converters directory with shared, beta, and stable modules, the code is now more organized, easier to maintain, and has less duplication. The use of structural typing in the shared converters to support both stable and beta SDKs is a great design choice. Overall, these changes significantly improve the codebase's structure. I have one minor suggestion to further improve conciseness in one of the new helper functions.
ad8332a to
e34b676
Compare
This PR restructures code a bit to extract out some shared logic, using structural types to keep them agnostic wrt the SDK namespaces.