-
Notifications
You must be signed in to change notification settings - Fork 631
docs: created a model spec doc to be used as reference by plugin devs #4060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @pavelgj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new documentation file that serves as a comprehensive specification for Genkit Model Actions. It aims to provide plugin developers with a clear reference for implementing models, covering their contract, required data structures, and expected behaviors. The document details how models should handle inputs, outputs, streaming, metadata, tool calls, and provider-specific configurations, ensuring consistency and interoperability across different model implementations within the Genkit framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new specification document for Genkit Model Actions. The document is comprehensive and well-structured, covering the model action definition, data structures, provider-specific features, and expected behaviors. This will be a valuable reference for plugin developers. However, I've found several discrepancies between the data structure definitions in this document and the actual TypeScript implementations. The documentation needs to be updated to accurately reflect which fields are optional and to include recent schema changes (e.g., raw and operation fields). I've also left a minor suggestion to improve the formality of the language in one section.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Explicitly mark essential fields as required across various data structures in the Model Specification to improve clarity and reduce ambiguity. Changes include: - Mark `messages` as required in `GenerateRequest`. - Update `request` in `GenerateResponse` to be required. - Mark `content` as required in `GenerateResponseChunk`. - Mark `role` and `content` as required in the `Message` definition.
Checklist (if applicable):