Skip to content

Conversation

@yesudeep
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the codebase's type safety by migrating the Python type checking infrastructure from mypy to ty. This change aims to leverage ty's capabilities for more rigorous type enforcement, ensuring higher code quality and reducing potential runtime errors. The modifications span across build scripts, development environment configurations, and dependency declarations to fully integrate the new type checker.

Highlights

  • Type Checker Migration: The project's Python type checker has been switched from mypy to ty to enable stricter type checks.
  • Build Script Updates: The bin/run_lint script and py/noxfile.py now invoke ty check instead of mypy for type verification.
  • Dependency Management: The py/pyproject.toml and py/uv.lock files have been updated to remove mypy as a linting dependency and include ty.
  • Configuration Removal: The dedicated [tool.mypy] configuration section has been removed from py/pyproject.toml as it is no longer needed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/python.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@yesudeep yesudeep force-pushed the yesudeep/feat/lyrical-spot branch from bc9423c to 0298bbd Compare January 10, 2026 06:17
@yesudeep yesudeep changed the title build(py/genkit): switch to ty for stricter type checks build(py/genkit): switch to ty for stricter and faster type checks Jan 10, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request switches the Python type checker from mypy to ty for stricter type checks. The changes correctly update the project dependencies, remove the old mypy configuration, and modify the linting scripts to use ty. The implementation is solid, but I have one suggestion to ensure consistency across different linting environments.

@yesudeep yesudeep enabled auto-merge (squash) January 10, 2026 06:18
@yesudeep yesudeep merged commit 7b91230 into main Jan 10, 2026
10 checks passed
@yesudeep yesudeep deleted the yesudeep/feat/lyrical-spot branch January 10, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config feature New feature or request python Python

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants