Skip to content

Conversation

@yesudeep
Copy link
Contributor

CHANGELOG:

  • Fix errors in py/bin/sanitize_schema_typing.py and typing.py
  • Format some pyproject.toml files

@github-actions github-actions bot added feature New feature or request python Python config labels Jan 10, 2026
@yesudeep yesudeep enabled auto-merge (squash) January 10, 2026 06:31
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the type correctness within the Python Genkit project by resolving reported type errors. It specifically addresses issues in the schema typing sanitizer and the core Message model's role field, making the type definitions more robust. Additionally, it includes minor cosmetic formatting changes to various pyproject.toml configuration files to maintain code style consistency.

Highlights

  • Type Error Resolution: Fixed type errors in the Python typing sanitizer (sanitize_schema_typing.py) and core typing definitions (typing.py), specifically related to Role type annotations and docstring handling.
  • Configuration Formatting: Applied minor formatting adjustments to several pyproject.toml files for consistency and readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily addresses type errors in the sanitize_schema_typing.py script and updates the generated typing.py file accordingly. The changes correctly adapt the AST parsing to be compatible with modern Python versions (3.8+) by handling ast.Constant for string literals. A new transformation is also added to handle the Role type. Additionally, some minor formatting changes are applied to pyproject.toml files. My main feedback is a minor code quality suggestion to restore a docstring that was converted to comments.

CHANGELOG:
- [ ] Fix errors in py/bin/sanitize_schema_typing.py and typing.py
- [ ] Format some pyproject.toml files
@yesudeep yesudeep force-pushed the yesudeep/feat/lyrical-spot branch from c840057 to acb8e0a Compare January 10, 2026 06:35
@yesudeep yesudeep merged commit 192cd7c into main Jan 10, 2026
10 checks passed
@yesudeep yesudeep deleted the yesudeep/feat/lyrical-spot branch January 10, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config feature New feature or request python Python

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants