fix(py): add static prompt fixtures and custom evaluator sample to match JS#4670
fix(py): add static prompt fixtures and custom evaluator sample to match JS#4670MengqinShen wants to merge 2 commits intomainfrom
Conversation
Summary of ChangesHello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Python Genkit framework by integrating static prompt definitions and introducing a robust sample for custom evaluators. The changes aim to bring the Python implementation closer to its JavaScript counterpart, particularly in how models are configured and prompts are managed. This includes porting existing prompt test fixtures and establishing a new sample that showcases various evaluation techniques, all while ensuring full compatibility and visibility within the Genkit Dev UI. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great addition, aligning the Python version of Genkit with the JavaScript version by adding static prompt fixtures and a new sample for custom evaluators. The new tests for static prompts are comprehensive. The custom evaluators sample is well-structured and provides clear examples of both LLM-based and non-LLM evaluators. I've found a few areas for improvement, mainly in the prompt files and configuration of the new sample, to enhance robustness and correctness. My detailed comments are below.
Ported static .prompt test fixtures from JavaScript to Python and created the framework-custom-evaluators sample. Refactored the model configuration to match JavaScript patterns (model-in-code rather than model-in-prompt) and ensured full Dev UI support.