Skip to content

Conversation

@andrewheard
Copy link
Contributor

Updated build-for-testing.sh to use Xcode 15.3. This is the current version supported by FTL:
FTL Xcode Selection Screenshot

This was increased to Xcode 16.1 in #1630 but tests are currently failing.

@andrewheard andrewheard marked this pull request as ready for review November 11, 2024 20:53
@andrewheard andrewheard requested a review from paulb777 November 11, 2024 20:53
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewheard
Copy link
Contributor Author

Thanks!

🤞 This will fix the quickstart-ftl-cron-only tests. I'll try by commenting out if: github.event_name == 'schedule'.

@andrewheard andrewheard merged commit 1a40e1e into main Nov 11, 2024
41 checks passed
@andrewheard andrewheard deleted the ah/build-for-testing-xc15-3 branch November 11, 2024 22:38
@andrewheard
Copy link
Contributor Author

Thanks!

🤞 This will fix the quickstart-ftl-cron-only tests. I'll try by commenting out if: github.event_name == 'schedule'.

Looks like this did the trick: https://github.com/firebase/firebase-ios-sdk/actions/runs/11787739992/job/32833585518?pr=14087#step:8:158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants