-
Couldn't load subscription status.
- Fork 1.5k
[firebaseai] Add onTapGesture to close keyboard #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @YoungHypo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on enhancing the user experience across several screens by implementing a common pattern for keyboard dismissal. Users can now tap outside of text input fields to hide the keyboard. Additionally, the ImagenScreen has received a structural refactor to optimize its layout and improve the presentation of its loading state.
Highlights
- Keyboard Dismissal: I've added an
onTapGesture { focusedField = nil }modifier to the main view hierarchy ofConversationScreen,PhotoReasoningScreen,GenerateContentScreen, andImagenScreen. This allows users to dismiss the software keyboard by tapping on any blank area of the screen, improving the overall user experience. - ImagenScreen Layout Refactor: In
ImagenScreen.swift, I've refactored the main container from aZStackto aScrollView. This change also involved removing a redundant innerScrollViewthat was wrapping theLazyVGrid, allowing the image grid to scroll naturally within the main view. - ImagenScreen Overlay Presentation: For
ImagenScreen.swift, the conditional display of theProgressOverlayhas been updated to use the.overlaymodifier, transitioning from anifstatement. This is a more idiomatic SwiftUI approach for presenting overlays.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
5bdbfd8 to
66fdbda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a tap gesture to several screens to allow dismissing the keyboard by tapping outside the input field, which is a good UX improvement. However, in ImagenScreen.swift, the refactoring introduces a couple of UI regressions: the input field no longer remains sticky at the top, and the progress indicator scrolls with the content. The review includes a suggested fix that resolves these issues while also improving the grid layout to be more robust by using GeometryReader instead of UIScreen.main.bounds.
solve issue #1720
Added
onTapGesture { focusedField = nil }to allowing the keyboard to be closed by tapping on a blank area, and the keyboard focus behavior remains unchanged.