Skip to content

Conversation

@YoungHypo
Copy link
Contributor

@YoungHypo YoungHypo commented Jun 26, 2025

solve issue #1720

Added onTapGesture { focusedField = nil } to allowing the keyboard to be closed by tapping on a blank area, and the keyboard focus behavior remains unchanged.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @YoungHypo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the user experience across several screens by implementing a common pattern for keyboard dismissal. Users can now tap outside of text input fields to hide the keyboard. Additionally, the ImagenScreen has received a structural refactor to optimize its layout and improve the presentation of its loading state.

Highlights

  • Keyboard Dismissal: I've added an onTapGesture { focusedField = nil } modifier to the main view hierarchy of ConversationScreen, PhotoReasoningScreen, GenerateContentScreen, and ImagenScreen. This allows users to dismiss the software keyboard by tapping on any blank area of the screen, improving the overall user experience.
  • ImagenScreen Layout Refactor: In ImagenScreen.swift, I've refactored the main container from a ZStack to a ScrollView. This change also involved removing a redundant inner ScrollView that was wrapping the LazyVGrid, allowing the image grid to scroll naturally within the main view.
  • ImagenScreen Overlay Presentation: For ImagenScreen.swift, the conditional display of the ProgressOverlay has been updated to use the .overlay modifier, transitioning from an if statement. This is a more idiomatic SwiftUI approach for presenting overlays.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a tap gesture to several screens to allow dismissing the keyboard by tapping outside the input field, which is a good UX improvement. However, in ImagenScreen.swift, the refactoring introduces a couple of UI regressions: the input field no longer remains sticky at the top, and the progress indicator scrolls with the content. The review includes a suggested fix that resolves these issues while also improving the grid layout to be more robust by using GeometryReader instead of UIScreen.main.bounds.

@paulb777 paulb777 merged commit 16e63d5 into firebase:main Jun 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants