Fix Catalyst build due to GoogleAdsOnDeviceConversion iOS-only support

[pcfba]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @pcfba, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on resolving a build issue that prevented the project from compiling correctly for Catalyst targets. The core of the fix involves a targeted modification in the Podfile to conditionally link an iOS-only framework, GoogleAdsOnDeviceConversion, thereby preventing conflicts on macOS. The accompanying changes in the Xcode project file are a direct result of CocoaPods re-integrating the project after this Podfile adjustment, ensuring all dependencies are correctly managed across platforms.

Highlights

• Catalyst Build Fix: I've implemented a post_install hook within the Podfile to ensure that the GoogleAdsOnDeviceConversion framework is only linked when building for iOS (iPhone) SDKs. This directly addresses and resolves the build failures previously encountered when compiling for Catalyst (macOS) targets, as this particular framework is designed exclusively for iOS.
• CocoaPods Project Integration: The analytics/AnalyticsExample.xcodeproj/project.pbxproj file has been updated to reflect the proper re-integration of CocoaPods dependencies. This includes adding new build file references, framework linking phases, and crucial shell script build phases (for [CP] Check Pods Manifest.lock and [CP] Embed Pods Frameworks). Additionally, base configuration references have been set to the CocoaPods-generated .xcconfig files across all relevant targets (iOS, macOS, tvOS, and their respective test targets) to ensure correct build settings inheritance.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a post_install script in the Podfile to conditionally include the GoogleAdsOnDeviceConversion framework for iPhone builds only. The review focuses on ensuring the script correctly modifies the xcconfig files without causing corruption or unintended side effects.

[ncooke3]

~Are the gemini code assist comments relevant? ~

nvm, refreshed and see you addressed them