feat: Remove ObjC quickstarts #1760
Conversation
find . -name "Legacy*Qui*" | xargs rm -rf
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant cleanup effort by eliminating all legacy Objective-C quickstart examples. This action simplifies the repository's structure, reduces maintenance overhead, and ensures that contributors and users are directed towards the most current and supported quickstart implementations.
Highlights
- Objective-C Quickstarts Removal: All Objective-C quickstart examples have been removed from the repository, streamlining the codebase and focusing on current language implementations.
- Associated Files Cleanup: Project files, source code, and resources specifically tied to the removed Objective-C quickstarts across various Firebase products (ABTesting, Analytics, Authentication, Config, Crashlytics, Storage) have been deleted.
- Documentation Updates: Relevant
README.mdfiles have been updated to remove references to the deprecated legacy quickstarts, ensuring documentation remains accurate and up-to-date.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is a significant cleanup, removing legacy Objective-C and Swift quickstart examples. The changes are extensive but appear consistent and well-executed. File deletions align with the goal of removing Legacy...Quickstart directories, and corresponding updates to README files and build scripts correctly remove references to the old code. The move of authentication/web/auth.html and its corresponding documentation update is a good detail. This is a valuable contribution to improving repository maintainability.
ncooke3
requested review from
paulb777,
andrewheard,
morganchen12 and
daymxn
Overall plan: