Skip to content

feat: set SPM=true by default for qs testing #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

feat: set SPM=true by default for qs testing #1767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ fi

# Set default parameters
if [[ -z "${SPM:-}" ]]; then
SPM=false
SPM=true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting SPM to true by default could potentially break existing setups that rely on the previous default (false). Consider adding a check to see if SPM is explicitly set to false before defaulting to true, or providing a clear migration path for users who depend on the old behavior.

if [[ -z "${SPM:-}" ]]; then
    SPM=true
    echo "Defaulting to SPM=$SPM"
fi

It might be better to check if it's explicitly set to false first.

Suggested change
SPM=true
if [[ -z "${SPM:-}" ]]; then
SPM=true
echo "Defaulting to SPM=$SPM"
fi

echo "Defaulting to SPM=$SPM"
fi
if [[ -z "${OS:-}" ]]; then
Expand Down
Loading