-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Remove legacy ObjC schemes #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nc/quickstarts
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a substantial cleanup effort across several example projects, including InAppMessaging, Installations, Messaging, and Performance. The core purpose is to eliminate all remnants of legacy Objective-C schemes and their associated files and configurations. By removing outdated Objective-C targets, source files, and build settings, the PR modernizes the project setup, reduces complexity, and ensures that the examples are aligned with current Swift-first development practices. This change simplifies future maintenance and development within these example applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great cleanup effort, removing a significant amount of legacy Objective-C code, schemes, and project configurations across several example projects. The changes make the projects much cleaner and easier to maintain. I've found one minor point of follow-up to make the cleanup even more complete, but overall this is a solid improvement.
No description provided.