Revert "Merge pull request #1806 from firebase/nc/quickstarts" #1811
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.github/workflows/analytics.yml
Outdated
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| name: cocoapods | ||
| runs-on: macOS-15 | ||
| env: | ||
| SPM: false | ||
| LEGACY: false | ||
| OS: iOS | ||
| SETUP: authentication | ||
| SPM: true | ||
| DIR: authentication | ||
| DEVICE: iPhone 16 | ||
| TEST: false | ||
| SCHEME: AuthenticationExample | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Setup | ||
| run: | | ||
| cd authentication | ||
| gem install bundler | ||
| bundle install | ||
| gem install xcpretty | ||
| cd $SETUP | ||
| ../scripts/install_prereqs/${SETUP}.sh | ||
| - name: Build and Test SwiftUI (${OS}) | ||
| bundle exec pod install --repo-update | ||
| ../scripts/install_prereqs/authentication.sh | ||
| - name: Build Swift | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SWIFT_SUFFIX: "" |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| name: cocoapods | ||
| runs-on: macOS-15 | ||
| env: | ||
| OS: iOS | ||
| DEVICE: iPhone 16 | ||
| DIR: config | ||
| SPM: true | ||
| SCHEME: ConfigExample | ||
| SPM: false | ||
| LEGACY: false | ||
| SWIFT_SUFFIX: "" | ||
| TEST: true | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| - name: Setup | ||
| run: | | ||
| cd config | ||
| gem install bundler | ||
| bundle install | ||
| gem install xcpretty | ||
| bundle exec pod install --repo-update | ||
| ../scripts/install_prereqs/config.sh | ||
| xcrun simctl boot "iPhone 16" | ||
| - name: Build Swift | ||
| run: ./scripts/test.sh | ||
| env: | ||
| OS: iOS | ||
| DEVICE: iPhone 16 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| name: cocoapods | ||
| runs-on: macOS-15 | ||
| env: | ||
| SPM: true | ||
| SPM: false | ||
| LEGACY: false | ||
| OS: iOS | ||
| DIR: firestore | ||
| DEVICE: iPhone 16 | ||
| TEST: false | ||
| SCHEME: FirestoreExample | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| - name: Setup | ||
| run: | | ||
| cd firestore | ||
| gem install bundler | ||
| bundle install | ||
| gem install xcpretty | ||
| bundle exec pod install --repo-update | ||
| ../scripts/install_prereqs/firestore.sh | ||
| - name: Build | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SWIFT_SUFFIX: "" |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| name: cocoapods | ||
| runs-on: macOS-15 | ||
| env: | ||
| SPM: true | ||
| DIR: inappmessaging | ||
| SPM: false | ||
| LEGACY: false | ||
| OS: iOS | ||
| DEVICE: iPhone 16 | ||
| TEST: false | ||
| TEST: true | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| - name: Setup | ||
| run: | | ||
| cd inappmessaging | ||
| gem install bundler | ||
| bundle install | ||
| gem install xcpretty | ||
| bundle exec pod install --repo-update | ||
| ../scripts/install_prereqs/inappmessaging.sh | ||
| - name: Build ObjC | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SWIFT_SUFFIX: "" | ||
| - name: Build Swift | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SCHEME: InAppMessagingExample | ||
| SWIFT_SUFFIX: Swift |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| name: cocoapods | ||
| runs-on: macOS-15 | ||
| env: | ||
| SPM: true | ||
| SPM: false | ||
| LEGACY: false | ||
| OS: iOS | ||
| DEVICE: iPhone 16 | ||
| TEST: true | ||
| DIR: installations | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| - name: Setup | ||
| run: | | ||
| cd installations | ||
| gem install bundler | ||
| bundle install | ||
| gem install xcpretty | ||
| bundle exec pod install --repo-update | ||
| ../scripts/install_prereqs/installations.sh | ||
| - name: Build ObjC | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SCHEME: InstallationsExample | ||
| SWIFT_SUFFIX: "" | ||
| - name: Build Swift | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SWIFT_SUFFIX: Swift |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| name: cocoapods | ||
| runs-on: macOS-15 | ||
| env: | ||
| SPM: true | ||
| SPM: false | ||
| LEGACY: false | ||
| OS: iOS | ||
| DEVICE: iPhone 16 | ||
| TEST: false | ||
| DIR: messaging | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@master | ||
| - name: Setup | ||
| run: | | ||
| cd messaging | ||
| gem install bundler | ||
| bundle install | ||
| gem install xcpretty | ||
| bundle exec pod install --repo-update | ||
| ../scripts/install_prereqs/messaging.sh | ||
| - name: Build | ||
| - name: Build ObjC | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SWIFT_SUFFIX: "" | ||
| - name: Build Swift | ||
| run: ./scripts/test.sh | ||
| env: | ||
| SCHEME: MessagingExample | ||
| SWIFT_SUFFIX: Swift |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Summary of ChangesHello @paulb777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves as a revert to a previous merge, primarily aimed at restoring quickstart examples to a functional state to resolve documentation build issues. It re-introduces older versions of quickstarts into dedicated legacy directories and shifts the dependency management strategy for several projects from Swift Package Manager to CocoaPods. Additionally, it includes updates to Xcode project configurations and minor code adjustments related to concurrency and network reachability. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a revert of a previous large-scale refactoring that introduced build breakages. The changes being reverted include moving several quickstart examples to 'Legacy' directories and migrating dependency management from CocoaPods to Swift Package Manager for multiple projects. Given that the goal is to restore the build to a working state, this revert is appropriate. The changes appear to correctly reverse the previous commit, and I see no issues with the revert itself.
2 participants
This reverts commit c39fe8d, reversing changes made to 251909a.
Restores quickstarts to avoid docs build breakage.
This may also break the nightlies in firebase-ios-sdk because of firebase/firebase-ios-sdk#15478 but that shouldn't break anyone outside the team and can wait until next week.