fix: modernize scripts/build-for-testing.sh

[ncooke3]

Unblocks firebase/firebase-ios-sdk#15530

• Add back storyboard
• Make FTL script for robust for handling different scheme names (some QS projects have OS dependent scheme names)

[gemini-code-assist]

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the scripts/build-for-testing.sh script to improve its robustness and flexibility. It introduces sensible default values for the target operating system and device, and significantly refines the process of selecting Xcode schemes for Swift Package Manager projects. These changes aim to streamline the build-for-testing workflow by making the script more adaptable to different project configurations and less prone to manual configuration errors.

Highlights

• Default OS and Device: The script now defaults the OS environment variable to iOS and DEVICE to iPhone if they are not explicitly set, providing more robust default testing environments.
• Dynamic Scheme Selection for SPM: The logic for selecting the Xcode scheme when using Swift Package Manager (SPM) has been modernized to dynamically query available schemes using xcodebuild -list, making it more flexible and less reliant on hardcoded values.
• Improved Scheme Selection Robustness: The scheme selection process now includes a fallback mechanism, checking for OS-suffixed, Swift-suffixed, and base scheme names, and provides enhanced error handling by exiting if no suitable scheme is found.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to modernize scripts/build-for-testing.sh. The changes align the script with scripts/test.sh, but I've found a critical issue where an undefined variable is used, which will cause the script to fail. Additionally, a fragile implementation for discovering Xcode schemes has been copied over; I've provided a suggestion for a more robust approach.

[paulb777]

LGTM - assuming the iOS build in CI is a flake?

[ncooke3]

@paulb777, yes. Thanks for reviews!