Skip to content

fix(FIR-50880): Async close failure #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

fix(FIR-50880): Async close failure #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/firebolt_db/firebolt_async_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ def _set_parameters(self) -> Dict[str, Any]:
def _set_parameters(self, value: Dict[str, Any]) -> None:
self._cursor._set_parameters = value

async def _async_soft_close(self) -> None:
"""close the cursor but keep the results pending, and memoize the
description.

We don't have ability to memorize results with async driver yet so
keeping this a no-op.

"""


class AsyncConnectionWrapper(AdaptedConnection):
await_ = staticmethod(await_only)
Expand Down