Add getStringArray helper to reduce getter boilerplate

Consolidates the repeated Array.isArray/split pattern into a single
private method used by all 7 array-type getters.

Author: firecow

src/argv.ts

@@ -120,6 +120,11 @@ export class Argv {
         }
     }
 
+    private getStringArray (key: string): string[] {
+        const val = this.map.get(key) ?? [];
+        return Array.isArray(val) ? val : val.split(" ");
+    }
+
     get cwd (): string {
         let cwd = this.map.get("cwd") ?? ".";
         assert(typeof cwd != "object", "--cwd option cannot be an array");
@@ -150,20 +155,11 @@ export class Argv {
         return (this.map.get("home") ?? process.env.HOME ?? "").replace(/\/$/, "");
     }
 
-    get volume (): string[] {
-        const val = this.map.get("volume") ?? [];
-        return Array.isArray(val) ? val : val.split(" ");
-    }
+    get volume (): string[] { return this.getStringArray("volume"); }
 
-    get network (): string[] {
-        const val = this.map.get("network") ?? [];
-        return Array.isArray(val) ? val : val.split(" ");
-    }
+    get network (): string[] { return this.getStringArray("network"); }
 
-    get extraHost (): string[] {
-        const val = this.map.get("extraHost") ?? [];
-        return Array.isArray(val) ? val : val.split(" ");
-    }
+    get extraHost (): string[] { return this.getStringArray("extraHost"); }
 
     get caFile (): string | null {
         return this.map.get("caFile") ?? null;
@@ -181,31 +177,24 @@ export class Argv {
         return this.map.get("pullPolicy") ?? "if-not-present";
     }
 
-    get remoteVariables (): string[] {
-        const val = this.map.get("remoteVariables") ?? [];
-        return Array.isArray(val) ? val : val.split(" ");
-    }
+    get remoteVariables (): string[] { return this.getStringArray("remoteVariables"); }
 
     get variable (): {[key: string]: string} {
-        const pairs = this.map.get("variable") ?? [];
         const variables: {[key: string]: string} = {};
-        (pairs).forEach((variablePair: string) => {
-            const exec = /(?<key>\w*?)(=)(?<value>(.|\n|\r)*)/.exec(variablePair);
+        for (const pair of this.getStringArray("variable")) {
+            const exec = /(?<key>\w*?)(=)(?<value>(.|\n|\r)*)/.exec(pair);
             if (exec?.groups?.key) {
-                variables[exec.groups.key] = exec?.groups?.value;
+                variables[exec.groups.key] = exec.groups.value;
             }
-        });
+        }
         return variables;
     }
 
     get unsetVariables (): string[] {
         return this.map.get("unsetVariable") ?? [];
     }
 
-    get manual (): string[] {
-        const val = this.map.get("manual") ?? [];
-        return Array.isArray(val) ? val : val.split(" ");
-    }
+    get manual (): string[] { return this.getStringArray("manual"); }
 
     get job (): string[] {
         return this.map.get("job") ?? [];
@@ -236,10 +225,7 @@ export class Argv {
         return this.map.get("privileged") ?? false;
     }
 
-    get device (): string[] {
-        const val = this.map.get("device") ?? [];
-        return Array.isArray(val) ? val : val.split(" ");
-    }
+    get device (): string[] { return this.getStringArray("device"); }
 
     get ulimit (): string | null {
         const ulimit = this.map.get("ulimit");