Skip to content

fix: Attempt to cut down start up time for downloaded files #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Attempt to cut down start up time for downloaded files #1616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/parser-includes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,18 @@
break;
} else {
const localFileName = `${cwd}/${stateDir}/includes/${gitData.remote.host}/${projectPath}/${ref}/${f}`;
// Check remotely only if the file does not exist locally
if (!fs.existsSync(localFileName) && !(await Utils.remoteFileExist(cwd, f, ref, domain, projectPath, gitData.remote.schema, gitData.remote.port))) {
const fileExists = fs.existsSync(localFileName);
// If the file already has been downloaded, skip it
if (fileExists) {
continue;
}

// Check remotely only if the file does not exist locally
const remoteFileExists = await Utils.remoteFileExist(cwd, f, ref, domain, projectPath, gitData.remote.schema, gitData.remote.port);
if (!remoteFileExists) {

Check failure on line 169 in src/parser-includes.ts

View workflow job for this annotation

GitHub Actions / eslint 

Trailing spaces not allowed
continue

Check failure on line 170 in src/parser-includes.ts

View workflow job for this annotation

GitHub Actions / eslint 

Missing semicolon
}

const fileDoc = {
include: {
project: projectPath,
Expand Down
Loading