Add GCL_VARIABLE_<name> env var support, replace yargs .env("GCL")

[firecow]

Summary

• Adds GCL_VARIABLE_<name>=<value> for injecting individual CI/CD variables via env
• Strips GCL_VARIABLE_* from process.env before yargs parse to avoid strictOptions() conflict
• Keeps .env("GCL") for standard options (validation, coercion, precedence, unknown-option rejection)
• CLI --variable flags take precedence over GCL_VARIABLE_* env vars

Example

GCL_VARIABLE_BUILD_FROM_SOURCE=false gitlab-ci-local --list

Test plan

• Unit tests for stripGclVariableEnvVars (4 tests)
• Unit tests for injectGclVariableEnvVars (7 tests)
• Integration test via subprocess with isolated env
• All variable-related test suites pass

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/test-cases/gcl-variable-env/integration.test.ts">

<violation number="1" location="tests/test-cases/gcl-variable-env/integration.test.ts:89">
P2: This integration test bypasses the `GCL_VARIABLE_*` code path by passing `variable` directly, so it would not catch a regression in env-var injection.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/test-cases/gcl-variable-env/integration.test.ts">

<violation number="1" location="tests/test-cases/gcl-variable-env/integration.test.ts:84">
P1: This test should not run concurrently while it mutates `process.env`; the shared global env can leak into other tests and cause nondeterministic failures.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

3 issues found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/argv.ts">

<violation number="1" location="src/argv.ts:46">
P1: Applying `GCL_*` values after `yargs.parse()` bypasses yargs validation and coercion for env-provided options.</violation>

<violation number="2" location="src/argv.ts:68">
P2: This default-value comparison lets `GCL_*` override an explicit CLI flag when the CLI value equals the option's default.</violation>
</file>

<file name="src/index.ts">

<violation number="1" location="src/index.ts:45">
P2: Injecting `GCL_*` values only inside the main handler regresses shell completion, because the `.completion(...)` path never sees those env-backed options.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/argv.ts">

<violation number="1" location="src/argv.ts:30">
P2: `GCL_VARIABLE_` (empty suffix) is not stripped from `env`, so yargs env parsing can still see an unexpected `GCL_VARIABLE_*` key.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

2 issues found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/argv.ts">

<violation number="1">
P2: `ignorePredefinedVars` can now be a string at runtime, causing substring-based whitelist checks instead of exact key matching.</violation>
</file>

<file name="src/index.ts">

<violation number="1">
P2: The coerce callback assumes a string, but yargs can pass an array for repeated flags; this can crash with `v.split is not a function`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud