Skip to content

Conversation

@austinvazquez
Copy link
Contributor

Issue #, if available:

Description of changes:
This change bumps the min Go version in go.mod to Go 1.23 to unblock dependabot PRs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@austinvazquez austinvazquez requested a review from a team as a code owner March 13, 2025 21:20
@austinvazquez austinvazquez force-pushed the bump-go-min-1.23 branch 5 times, most recently from ae2f707 to 08f1d27 Compare March 14, 2025 02:14
Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez
Copy link
Contributor Author

Created a handful of issues to resolve lint warnings which were non-trivial to resolve here.
#806

BuildKite build is successful.
https://buildkite.com/firecracker-microvm/firecracker-containerd/builds/4336#_

Copy link
Contributor

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved anyway, since my only comment was in a change to test code.

@austinvazquez
Copy link
Contributor Author

Pulling this in to unblock dependabot PRs. Happy to address any feedback separately if required.

@austinvazquez austinvazquez merged commit 9576907 into firecracker-microvm:main Mar 17, 2025
5 checks passed
@austinvazquez austinvazquez deleted the bump-go-min-1.23 branch March 17, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants