Open
Conversation
coderbirju
force-pushed
the
fix-test-failures
branch
from
b6d5537 to
6e6d0dc
Compare
coderbirju
force-pushed
the
fix-test-failures
branch
25 times, most recently
from
f0a783f to
a0c8483
Compare
coderbirju
force-pushed
the
fix-test-failures
branch
2 times, most recently
from
0d4d785 to
de08c40
Compare
coderbirju
force-pushed
the
fix-test-failures
branch
6 times, most recently
from
8aa17b9 to
b5f0cd4
Compare
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
When the agent receives a Shutdown request, it may close the ttrpc connection before sending the response. This is expected behavior. The runtime should proceed to Wait() for the VM to exit rather than treating this as a failure and force-terminating. Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
…r subtest Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
coderbirju
force-pushed
the
fix-test-failures
branch
2 times, most recently
from
23f5494 to
1ff34b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Our CI experiences two categories of failures:
Most of these failures happens either because of timing delays during agent setup and cleanup, some I have tried to alleviate this by adding timeouts and individual contexts in as many places as possible but it is not consistent and the only way to get this to be consistent is probably look into how the tests are structured.
Recent changes include runc update, firecracker-go-sdk update and various other small dependencies being updated, including the docker image used for testing. Any of these can be a reason for added flakyness.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.