Support jailer cgroup args #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Duffany <[email protected]>
bduffany
force-pushed
the
cgroup-values
branch
from
c7242ec to
82d24f5
Compare
Contributor
|
Thanks! Changes look good to me, will run testing suite and see if I can get another member to review this. |
henry118
approved these changes
Nov 11, 2024
swagatbora90
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: This PR adds support for passing
--cgroupargs tojailervia theJailerCommandBuilder. It is intended as a slightly simpler alternative to https://github.com/firecracker-microvm/firecracker-go-sdk/pull/493/files which has been rebased on main. This simplified PR does not make any changes to the existingNumaNodeconfiguration; instead, it just adds clarification thatWithNumaNodeis a shorthand forWithCgroupArgs("cpuset.cpus=...", "cpuset.mems=...")By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.