rename max payload size cmdline argument

Signed-off-by: Luminita Voicu <[email protected]>

Author: luminitavoicu

CHANGELOG.md

@@ -4,9 +4,9 @@
 
 ### Added
 
-- Added `--http_api_max_payload_size` parameter to configure the maximum payload
+- Added `--http-api-max-payload-size` parameter to configure the maximum payload
   size for PUT and PATCH requests.
-- Limit MMDS data store size to `--http_api_max_payload_size`.
+- Limit MMDS data store size to `--http-api-max-payload-size`.
 - Cleanup all environment variables in Jailer.
 
 ## [0.25.0]

docs/mmds/mmds-design.md

@@ -59,7 +59,7 @@ store supports at the moment storing and retrieving JSON values. Data store
 contents can be retrieved using the Firecracker API server from host and using
 the embedded MMDS HTTP/TCP/IPv4 network stack from guest.
 MMDS data store is upper bounded by a default maximum size of 51200 bytes. This
-limit can be modified using `--http_api_max_payload_size` command line parameter.
+limit can be modified using `--http-api-max-payload-size` command line parameter.
 All PUT and PATCH requests with Content-Length bigger than the imposed limit will
 receive HTTP 413 Payload Too Large response status code.
 

src/firecracker/src/main.rs

@@ -202,7 +202,7 @@ fn main_exitable() -> ExitCode {
                 .help("Print the data format version of the provided snapshot state file.")
         )
         .arg(
-            Argument::new("http_api_max_payload_size")
+            Argument::new("http-api-max-payload-size")
                 .takes_value(true)
                 .help("Http API request payload max size.")
         );
@@ -309,10 +309,10 @@ fn main_exitable() -> ExitCode {
             .expect("Missing argument: api-sock");
         let payload_limit = arg_parser
             .arguments()
-            .single_value("http_api_max_payload_size")
+            .single_value("http-api-max-payload-size")
             .map(|lim| {
                 lim.parse::<usize>()
-                    .expect("'http_api_max_payload_size' parameter expected to be of 'usize' type.")
+                    .expect("'http-api-max-payload-size' parameter expected to be of 'usize' type.")
             });
 
         let start_time_us = arguments.single_value("start-time-us").map(|s| {

tests/integration_tests/functional/test_cmd_line_start.py

@@ -111,7 +111,7 @@ def test_config_start_with_limit(test_microvm_with_api, vm_config_file):
     test_microvm = test_microvm_with_api
 
     _configure_vm_from_json(test_microvm, vm_config_file)
-    test_microvm.jailer.extra_args.update({'http_api_max_payload_size': "250"})
+    test_microvm.jailer.extra_args.update({'http-api-max-payload-size': "250"})
     test_microvm.spawn()
 
     response = test_microvm.machine_cfg.get()