Skip to content

Commit 2689dd6

Browse files
pb8oroypat
authored andcommitted
test: drop support for unsupported versions
v1.6.0 has been EOL for a few months already. Signed-off-by: Pablo Barbáchano <[email protected]>
1 parent c4313b3 commit 2689dd6

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

tests/framework/artifacts.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from pathlib import Path
99
from typing import Iterator
1010

11-
import packaging.version
1211
import pytest
1312

1413
from framework.defs import ARTIFACT_DIR
@@ -98,9 +97,6 @@ def snapshot_version_tuple(self):
9897
# independent of Firecracker versions. For these Firecracker versions, use
9998
# the --snapshot-version Firecracker flag, to figure out which snapshot version
10099
# it supports.
101-
# TODO: remove this check once all version up to (and including) 1.6.0 go out of support.
102-
if packaging.version.parse(self.version) < packaging.version.parse("1.7.0"):
103-
return self.version_tuple[:2] + (0,)
104100

105101
return (
106102
check_output([self.path, "--snapshot-version"])

tests/integration_tests/functional/test_cmd_line_parameters.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import subprocess
66
from pathlib import Path
77

8-
import packaging.version
98
import pytest
109

1110
from framework.utils import check_output
@@ -22,14 +21,6 @@ def test_describe_snapshot_all_versions(
2221
snapshot state file.
2322
"""
2423

25-
# TODO: remove this check once all versions prior to 1.6.0 go out of support.
26-
if packaging.version.parse(firecracker_release.version) < packaging.version.parse(
27-
"1.7.0"
28-
):
29-
pytest.skip(
30-
"We can't parse snapshot files created from Firecracker with version < 1.7.0."
31-
)
32-
3324
target_version = firecracker_release.snapshot_version
3425
vm = microvm_factory.build(
3526
guest_kernel,

0 commit comments

Comments
 (0)