test: eliminate Microvm.expect_kill_by_signal

All tests that formerly set this property now use `mark_killed`. The
only other location that set this value was `kill()` itself, to avoid
errors when kill() ends up being called twice. However, this is already
managed by the `Microvm._killed` attribute, so this guarding is not
necessary. Thus, remove the `expect_kill_by_signal`, as it is useless.

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

tests/framework/microvm.py

@@ -244,9 +244,6 @@ def __init__(
 
         self._numa_node = numa_node
 
-        # Flag checked in destructor to see abnormal signal-induced crashes.
-        self.expect_kill_by_signal = False
-
         # MMDS content from file
         self.metadata_file = None
 
@@ -285,18 +282,14 @@ def kill(self):
         self.disks_vhost_user.clear()
 
         assert (
-            self.expect_kill_by_signal
-            or "Shutting down VM after intercepting signal" not in self.log_data
+            "Shutting down VM after intercepting signal" not in self.log_data
         ), self.log_data
 
         try:
             if self.firecracker_pid:
                 os.kill(self.firecracker_pid, signal.SIGKILL)
 
             if self.screen_pid:
-                # Killing screen will send SIGHUP to underlying Firecracker.
-                # Needed to avoid false positives in case kill() is called again.
-                self.expect_kill_by_signal = True
                 os.kill(self.screen_pid, signal.SIGKILL)
         except:
             LOG.error(self.log_data)