feat(jailer): remove requirement for an executable name

Now jailer will not complain if the executable does
not contain `firecracker` in it's name. This restriction
was unnecessary and it's removal is not a breaking change.

Signed-off-by: Egor Lazarchuk <[email protected]>

Author: ShadowCurse

src/jailer/src/env.rs

@@ -301,10 +301,6 @@ impl Env {
             .unwrap()
             .to_string();
 
-        if !exec_file_name.contains("firecracker") {
-            return Err(JailerError::ExecFileName(exec_file_name));
-        }
-
         Ok((exec_file_path, exec_file_name))
     }
 
@@ -1048,17 +1044,6 @@ mod tests {
             "/tmp/firecracker_test_dir is not a file"
         );
 
-        // Error case 3: Filename without "firecracker"
-        File::create("/tmp/firecracker_test_dir/foobarbaz").unwrap();
-        assert_eq!(
-            format!(
-                "{}",
-                Env::validate_exec_file("/tmp/firecracker_test_dir/foobarbaz").unwrap_err()
-            ),
-            "Invalid filename. The filename of `--exec-file` option must contain \"firecracker\": \
-             foobarbaz"
-        );
-        std::fs::remove_file("/tmp/firecracker_test_dir/foobarbaz").unwrap();
         std::fs::remove_dir_all("/tmp/firecracker_test_dir").unwrap();
     }
 

src/jailer/src/main.rs

@@ -73,10 +73,6 @@ pub enum JailerError {
     Dup2(io::Error),
     #[error("Failed to exec into Firecracker: {0}")]
     Exec(io::Error),
-    #[error(
-        "Invalid filename. The filename of `--exec-file` option must contain \"firecracker\": {0}"
-    )]
-    ExecFileName(String),
     #[error("{}", format!("Failed to extract filename from path {:?}", .0).replace('\"', ""))]
     ExtractFileName(PathBuf),
     #[error("{}", format!("Failed to open file {:?}: {}", .0, .1).replace('\"', ""))]

tests/integration_tests/security/test_jail.py

@@ -106,20 +106,6 @@ def test_exec_file_not_exist(uvm_plain, tmp_path):
     ):
         test_microvm.spawn()
 
-    # Error case 3: Filename without "firecracker"
-    pseudo_exec_file_path = tmp_path / "foobarbaz"
-    pseudo_exec_file_path.touch()
-    fc_dir = Path("/srv/jailer") / pseudo_exec_file_path.name / test_microvm.id
-    fc_dir.mkdir(parents=True, exist_ok=True)
-    test_microvm.jailer.exec_file = pseudo_exec_file_path
-
-    with pytest.raises(
-        Exception,
-        match=r"Jailer error: Invalid filename. The filename of `--exec-file` option"
-        r' must contain "firecracker": foobarbaz',
-    ):
-        test_microvm.spawn()
-
 
 def test_default_chroot_hierarchy(uvm_plain):
     """