-
Notifications
You must be signed in to change notification settings - Fork 2.2k
ci: Test for unused dependencies #4117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Test for unused dependencies #4117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 251 251
Lines 27889 27889
=======================================
Hits 23422 23422
Misses 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b706bfd to
03cca76
Compare
|
Blocked on docker changes from: #4089 |
|
Unblocked :) |
|
#4089 merged, unblocked. |
96cde67 to
08d6250
Compare
2ed8ef8 to
0d7731f
Compare
0d7731f to
542db3d
Compare
542db3d to
37bc244
Compare
bchalios
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please break this down to two commits, one that adds the test (test, Docker changes) and one that removes the unused dependencies?
Also, there are here, seemingly, completely unrelated changes (the ones in the documentation). Please drop these and add them in a different PR.
498b576 to
2830e0d
Compare
I've updated the PR breaking it down into 4 commits.
These are required by the updated version of markdown lint. |
2830e0d to
5a31450
Compare
5a31450 to
360d99a
Compare
360d99a to
65859ba
Compare
65859ba to
4859a5a
Compare
Add a `nightly` flag to the `cargo` function, which causes the requested command to be executing using the nightly toolchain. We have a nightly toolchain in our container due to kani. But since the toolchain version is prescribed by kani, we need to dynamically determine its name from `rustup toolchain list`, and cannot just use `+nightly`. Signed-off-by: Patrick Roy <[email protected]>
From: Jonathan Woollett-Light <[email protected]> Adds test for unused cargo dependencies. Signed-off-by: Jonathan Woollett-Light <[email protected]> Co-authored-by: Patrick Roy <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
The new test caught these. yay! Signed-off-by: Patrick Roy <[email protected]>
Changes
Adds a test for unused cargo dependencies.
Reason
Prevents including unused dependencies see #4113 (comment).
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.