-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Increase timeout of kani tests #4765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout of kani tests #4765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also pass a timeout to utils.check_output
(say of 20 seconds less than the timeout applied by pytest), so that if we do get a timeout again, it'll actually print the kani stdout which will tell us what specific harness timed out
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4765 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 249 249
Lines 27460 27460
=======================================
Hits 23160 23160
Misses 4300 4300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Does it make sense to only apply the timeout in |
df61bd1
to
1b64879
Compare
Some changes that we did in the VirtIO queue in this PR: firecracker-microvm#4726 pushed kani proofs close to the time limit we set in the CI. This commit just increases the timeout from 30 to 40 minutes. Signed-off-by: Babis Chalios <[email protected]>
1b64879
to
c633fd0
Compare
If we don't set a pytest timeout, the default of 180s will apply, so we need to overwrite it explicitly :( |
Changes
Increase the timeout for kani test from 30 to 40 minutes.
Reason
Some changes that we did in the VirtIO queue in this PR: #4726 pushed kani proofs close to the time limit we set in the CI.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.