test: do not perf test with no-acpi kernels #4767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
force-pushed
the
no-acpi-for-perf-tests
branch
2 times, most recently
from
3076a0e to
3478acc
Compare
kernels_unfiltered was not used anywhere (as evidenced to it still referring to no-sve kernels, which are gone since we dropped 4.14 host support). Signed-off-by: Patrick Roy <[email protected]>
Using guests without ACPI support is deprecated, but we need to functionally verify it until we can remove support in Firecracker 2.0. However, we definitely do not need to performance test this configuration. So don't, and speed up our perf tests by 25%. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
no-acpi-for-perf-tests
branch
from
6e13d32 to
613232e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4767 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 249 249
Lines 27460 27460
=======================================
Hits 23160 23160
Misses 4300 4300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This fixture is used by tests that explicitly do not care about the specific guest kernel version (for example negative tests that ensure firecracker doesn't allow specific combinations of API requests), so do not run all these tests twice because of the no-acpi kernel. Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
pb8o
approved these changes
Sep 2, 2024
ShadowCurse
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using guests without ACPI support is deprecated, but we need to
functionally verify it until we can remove support in Firecracker 2.0.
However, we definitely do not need to performance test this
configuration. So don't, and speed up our perf tests by 25%.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.