fix(changelog): add entry about virtio-net feature negotiation fix #4769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
added
the
Status: Awaiting review
pb8o
previously approved these changes
Sep 2, 2024
roypat
reviewed
Sep 2, 2024
Adds an entry in CHANGELOG.md about the fix firecracker-microvm#4680. The fix ensures that we set to the TAP device only features that were successfully negotiated with the guest driver. Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
add_tap_fix_in_changelog
branch
from
62fef42 to
2ca1b1f
Compare
kalyazin
approved these changes
Sep 2, 2024
roypat
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an entry in CHANGELOG.md about the fix
#4680. The fix ensures that we set to the TAP device only features that were successfully negotiated with the guest driver.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.