Skip to content

Conversation

bchalios
Copy link
Contributor

@bchalios bchalios commented Sep 2, 2024

Changes

Update version number / CHANGELOG / CREDITS

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@bchalios bchalios added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (8b3b8f4) to head (1bdcc78).
Report is 3 commits behind head on firecracker-v1.9.

Additional details and impacted files
@@                Coverage Diff                @@
##           firecracker-v1.9    #4771   +/-   ##
=================================================
  Coverage             84.34%   84.34%           
=================================================
  Files                   249      249           
  Lines                 27461    27461           
=================================================
  Hits                  23162    23162           
  Misses                 4299     4299           
Flag Coverage Δ
5.10-c5n.metal 84.57% <ø> (ø)
5.10-m5n.metal 84.55% <ø> (-0.01%) ⬇️
5.10-m6a.metal 83.84% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.91% <ø> (ø)
5.10-m6i.metal 84.55% <ø> (ø)
5.10-m7g.metal 80.91% <ø> (ø)
6.1-c5n.metal 84.57% <ø> (ø)
6.1-m5n.metal 84.55% <ø> (ø)
6.1-m6a.metal 83.84% <ø> (-0.01%) ⬇️
6.1-m6g.metal 80.91% <ø> (ø)
6.1-m6i.metal 84.54% <ø> (ø)
6.1-m7g.metal 80.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o added the Release Indicates that an issue or pull request is part of the next release label Sep 2, 2024
Copy link
Contributor

@pb8o pb8o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to forward-port CREDITS.md and .mailmap so we don't keep having to update those.

@bchalios
Copy link
Contributor Author

bchalios commented Sep 2, 2024

@pb8o I did the CREDITS fixes. Could you please take another look?

Update with new entries and de-duplicate some of the existing

(cherry picked from commit 819a9f6)

Signed-off-by: Babis Chalios <[email protected]>
Mention 6.1 guest kernel in the test matrix we maintain in README.md

(cherry picked from commit e454d3c)

Signed-off-by: Babis Chalios <[email protected]>
Update version number / CHANGELOG / CREDITS

Signed-off-by: Babis Chalios <[email protected]>
@bchalios bchalios merged commit e58dbc0 into firecracker-microvm:firecracker-v1.9 Sep 2, 2024
4 of 5 checks passed
@bchalios bchalios deleted the firecracker-v1.9 branch September 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Indicates that an issue or pull request is part of the next release Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants